In theory `handle_child_pad_removed/4` is an optional callback, isn't it?

We have recently released `membrane_rtc_engine` `v0.15.0` with dependency to the `membrane_core` `v0.12`. Do you observe this same error with this version of RTC Engine?

With membrane_core v0.12.3 it is fine indeed.

I mean, it does not crash on that version but this is not fine 😉

Does this error occur, when you try to remove your own custom endpoint, or maybe the one of the endpoints from `membrane_rtc_engine` package?

Do you mean, that this error occurs on `membrane_core` `v0.12.5`, but not on `v0.12.3`?

It is not required to implement `handle_child_pad_removed/4` callback in the bins and pipelines, but if you don't do this, you won't be able to handle situation, when a child removes its own pad

This error occurs when the RTC engine removes a WebRTC endpoint. It happens when using membrane_core v0.12.5 but not on v.0.12.3!

You can open an issue describing this problem with steps to reproduce it, this will help us debug this problem

Yep still on it though, it looks like it is happening on v0.12.3 as well. I'll be back as soon as I have more details

OK, just scraping the surface. membrane_core is indeed calling `handle_child_pad_removed` on the `Membrane.RTC.Engine` pipeline for some reason and it is crashing because that function is not present in there. The problem is that either the RTC.Engine should have implemented this *optional* callback but it didn't or membrane_core is not treating that callback as not optional after all. I can confirm this is happening with membrane_core v0.12.3 as well! I'll have another look tomorrow, bye for now

Hi dmorn, do you still have that problem? Or can we mark this thread as solved?

Crash in RTC engine when removing endpoints

dmorn

13 responses

Join out Discord Community